Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctype: Provide fast macro implementation #277

Merged
merged 1 commit into from
Aug 11, 2023
Merged

ctype: Provide fast macro implementation #277

merged 1 commit into from
Aug 11, 2023

Conversation

agkaminski
Copy link
Member

@agkaminski agkaminski commented Aug 8, 2023 •
edited
Loading

DONE: RTOS-549

Description

Fixes phoenix-rtos/phoenix-rtos-project#782

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

gerard5
gerard5 previously approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@gerard5 gerard5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick check, works for me.
2023-08-08-160615_1137x467_scrot

xvuko
xvuko reviewed Aug 8, 2023
View reviewed changes
include/ctype.h Outdated Show resolved Hide resolved
include/ctype.h Outdated Show resolved Hide resolved
@agkaminski agkaminski marked this pull request as draft August 9, 2023 09:27
@agkaminski agkaminski changed the title ctype: Make functions static inline, move to the header ctype: Provide fast macro implementation Aug 9, 2023
@agkaminski agkaminski marked this pull request as ready for review August 9, 2023 10:18
github-actions[bot]
github-actions bot reviewed Aug 9, 2023
View reviewed changes
include/ctype.h Outdated Show resolved Hide resolved
anglov
anglov reviewed Aug 9, 2023
View reviewed changes
include/ctype.h Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Aug 9, 2023
View reviewed changes
include/ctype.h Outdated Show resolved Hide resolved
include/ctype.h Outdated Show resolved Hide resolved
include/ctype.h Outdated Show resolved Hide resolved
include/ctype.h Outdated Show resolved Hide resolved
include/ctype.h Outdated Show resolved Hide resolved
include/ctype.h Outdated Show resolved Hide resolved
include/ctype.h Outdated Show resolved Hide resolved
include/ctype.h Outdated Show resolved Hide resolved
include/ctype.h Outdated Show resolved Hide resolved
include/ctype.h Outdated Show resolved Hide resolved
anglov
anglov previously approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@anglov anglov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me in terms of C99/POSIX purism. It would be great if you could rerun test.

Looking at code generation (root @xvuko cause) would also be advisible.

gerard5
gerard5 reviewed Aug 9, 2023
View reviewed changes
include/ctype.h Outdated Show resolved Hide resolved
@agkaminski agkaminski merged commit 04a2c0a into master Aug 11, 2023
25 checks passed
@agkaminski agkaminski deleted the agkaminski/rtos-549 branch August 11, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerard5 gerard5 gerard5 left review comments

@github-actions GitHub Actions GitHub Actions left review comments

@anglov anglov anglov approved these changes

@xvuko xvuko Awaiting requested review from xvuko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<ctype.h> functions should support code inlining
4 participants
@agkaminski @gerard5 @anglov @xvuko